Skip to content

Bug fix: Update index.ts to remove toReactElement.ts #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jasongitmail
Copy link
Contributor

Easier to communicate via a minimal PR. I didn't remove the toReactElement.ts file though.

Bug:

  1. npm i @ethercorps/sveltekit-og
  2. Add code from https://github.com/etherCorps/sveltekit-og#quick-start
  3. Visit http://localhost:5173/og. This error is returned:
Internal server error: Cannot find module '/myapp/node_modules/@ethercorps/sveltekit-og/toReactElement' imported from /myapp/node_modules/@ethercorps/sveltekit-og/index.js

Making the changes in the PR removes this error and allows the image to be generated.

@vercel
Copy link

vercel bot commented Jun 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sveltekit-og ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2023 1:57pm

@theetherGit
Copy link
Collaborator

@jasongitmail I'm looking into it just give me some time.

@theetherGit
Copy link
Collaborator

@jasongitmail as you can see i made a mistake in toReactElement file. it's fixed now

@theetherGit theetherGit closed this Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants