Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing line numbers in timeslider #4669

Open
webzwo0i opened this issue Jan 22, 2021 · 2 comments
Open

Missing line numbers in timeslider #4669

webzwo0i opened this issue Jan 22, 2021 · 2 comments

Comments

@webzwo0i
Copy link
Member

webzwo0i commented Jan 22, 2021

I think this worked once, maybe it was removed intentionally, but I thought it is useful

On
https://video.etherpad.com/p/list-numbering/timeslider#165
the line numbers are not shown

@JohnMcLear
Copy link
Member

JohnMcLear commented Sep 9, 2021

Timeslider never had line numbers(or didn't since before 1.8.0) and this was never reported as a bug.

@JohnMcLear
Copy link
Member

JohnMcLear commented Sep 9, 2021

https://www.npmjs.com/package/ep_timesliderdiff is worth referring to here. Note that timeslider never had line numbers, not even back in the day..

So is this a bug? I don't think so, but I would say that your line numbers should be present in the timeslider if you have them present in the editor.

It's technically not a bug tho as it's expected behaviour at this point albeit not ideal 🖌️

@JohnMcLear JohnMcLear removed their assignment Sep 9, 2021
@JohnMcLear JohnMcLear changed the title Missing line numbers in timeslider - regression? Missing line numbers in timeslider Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants