Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call for Input: Fix Comment in ERC-3448 #343

Closed
9 tasks done
SamWilsn opened this issue Jun 28, 2024 · 4 comments
Closed
9 tasks done

Call for Input: Fix Comment in ERC-3448 #343

SamWilsn opened this issue Jun 28, 2024 · 4 comments

Comments

@SamWilsn
Copy link
Collaborator

Call for Input

Decision

Do we merge ethereum/ERCs#429?

If Affirmed

Comment in reference implementation is changed.

If Rejected

ERC-3448 is unchanged.

Method

Rough Consensus

Deadline

July 28, 2024

Checklist

I, the opener of this Call for Input, have completed the following:

  • Filled in a descriptive title.
  • Filled in the "Decision" field.
  • Filled in the "If Affirmed" field.
  • Filled in the "If Rejected" field.
  • Filled in the "Method" field.
  • Filled in the "Deadline" field to be thirty days from creation.
  • Added any relevant background information (or removed the section.)
  • Published a notice in writing to the usual channels frequented by EIP Editors (likely Discord.)
  • Commented on this Call for Input, clearly stating my opinion (or abstention.)
@SamWilsn
Copy link
Collaborator Author

I'm in favour of merging, after a quick bytecode scan.

@poojaranjan poojaranjan mentioned this issue Jun 28, 2024
18 tasks
@abcoathup
Copy link

Given it is correcting a comment, if the ERC author approves then I'm ok with this, even though I am generally against changing final ERCs. The discussions topic on Eth Magicians should be changed to a wiki post and have a corrections section.

@g11tech
Copy link

g11tech commented Jun 29, 2024

ok with the change

@poojaranjan poojaranjan mentioned this issue Jul 4, 2024
10 tasks
@lightclient
Copy link

seems okay

@poojaranjan poojaranjan mentioned this issue Jul 19, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants