Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete temporary test objects immediately #90

Closed
cportele opened this issue Mar 31, 2020 · 1 comment
Closed

Delete temporary test objects immediately #90

cportele opened this issue Mar 31, 2020 · 1 comment
Labels
EIP-approved EIP approved by the Steering Group Impl. EIP has been implemented and is ready for the next release. Doc might be incomplete (temp. label)
Milestone

Comments

@cportele
Copy link
Contributor

ETF Improvement Proposal (EIP)

Background and Motivation:

Currently test objects and related data are deleted using a queue and resources are deleted with a delay. This behaviour has two drawbacks:

  • Sensitive data, e.g. with personal information, should be deleted without delay from the systems.
  • On systems that are used for mass testing, many test objects may still be temporarily on the system after the test runs finish

Proposed change

There are two types of test objects:

  • temporary test objects, which are provided in the context of a single test run
  • persistent test objects, which are stored independent of test runs (see the EIP #26)

For each test object three types of data can be distinguished:

  • the source data (e.g. a set of GML documents)
  • index data to improve the execution of the tests (e.g., the BaseX database with the GML documents and the associated indices)
  • metadata (timestamp of last access, the URL of remote files or services)

For temporary test objects: Delete all source and index data at the end of the test run. The metadata is deleted once the test report is deleted.

For persistent test objects: Delete all source and index data once the persistent test object is deleted. The metadata is deleted, if the persistent test object has been deleted and once the last test report for this test object is deleted.

Alternatives

The current behaviour could have been kept as the default and the new behaviour could have been triggered with an additional flag during the creation of a temporary test object or a test run. However, changing the default behaviour does not have any negative impact on existing users, but avoids a change in the API and keeps the code easier to maintain.

Funding

Yes

Additional information

This could also help with issue #208.

@cportele cportele added the EIP Improvement Proposal. Put up for discussion. label Mar 31, 2020
@cportele cportele added EIP-approved EIP approved by the Steering Group and removed EIP Improvement Proposal. Put up for discussion. labels Apr 1, 2020
@jonherrmann jonherrmann added the Impl. EIP has been implemented and is ready for the next release. Doc might be incomplete (temp. label) label May 23, 2022
@jonherrmann
Copy link
Contributor

Implemented in Version 2.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EIP-approved EIP approved by the Steering Group Impl. EIP has been implemented and is ready for the next release. Doc might be incomplete (temp. label)
Projects
None yet
Development

No branches or pull requests

2 participants