Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS bug? #78

Closed
nuno84 opened this issue Jun 18, 2018 · 2 comments
Closed

JS bug? #78

nuno84 opened this issue Jun 18, 2018 · 2 comments

Comments

@nuno84
Copy link
Contributor

nuno84 commented Jun 18, 2018

Hi etewiah,
I've been working and evaluating your project.
I found some minor bugs and tried to understand and contribute, but as I can see, the JS section has been minified and thus, impossible to edit.
For instance, I was trying to understand why the item in the image below has the buttons active (it is the only one), but it is processed in the JS and thus, I cannot get it.
Thank you

image

@etewiah
Copy link
Owner

etewiah commented Jun 18, 2018

Hi @nuno84 , thanks for your interest in the project.

The code for the javascript used by the admin panel is here:

https://github.com/etewiah/property_web_builder_admin

It is built with ember.js but I am working on migrating it to vue.js:

#49

What you have noticed is not a bug. When you change the text, those buttons appear so you can either save or cancel your change.

@nuno84
Copy link
Contributor Author

nuno84 commented Jun 19, 2018

Hi etewiah,
The interesting is that I didn't change the text at all but those buttons appeared by default on that item.
I was going to chase the issue but then I couldn't read the JS.
Also, note that the tooltips say that it couldn't find the translation and I am not sure where (the language is in English, but it also fails in other languages)
Thank you

image

@etewiah etewiah closed this as completed Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants