Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.4] Update go version to 1.20.12 #17076

Merged

Conversation

jonasrdl
Copy link
Contributor

@jonasrdl jonasrdl commented Dec 6, 2023

Updates go version to 1.20.12 for release-3.4

#17049

@k8s-ci-robot
Copy link

Hi @jonasrdl. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

.go-version Outdated
@@ -1 +1 @@
1.20.11
1.21.5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1.21.5
1.20.12

go.mod Outdated
@@ -1,6 +1,6 @@
module go.etcd.io/etcd

go 1.20
go 1.21
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
go 1.21
go 1.20

@ahrtr ahrtr changed the title Update go version to 1.21.5 [3.4] Update go version to 1.20.12 Dec 6, 2023
@jonasrdl jonasrdl force-pushed the release-3.4-update-to-go-1.21.5 branch from e0881cf to 116813f Compare December 6, 2023 18:58
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for raising this @jonasrdl, apologies I neglected to mention in the github issue that release branches are to go to 1.20.12 not 1.21.5.

There are a few more mentions to update in this branch before we merge:

 james  ~  Documents  etcd  ?2  release-3.4-updat..                                                                                                        08:02:17 
 ➜ git grep 1.20.11
Makefile:GO_VERSION ?= 1.20.11
functional/scripts/docker-local-agent.sh:  GO_VERSION=1.20.11
functional/scripts/docker-local-tester.sh:  GO_VERSION=1.20.11

@jmhbnz
Copy link
Member

jmhbnz commented Dec 6, 2023

/ok-to-test

Signed-off-by: Jonas Riedel <jonasriedel@pm.me>
@jonasrdl jonasrdl force-pushed the release-3.4-update-to-go-1.21.5 branch from 116813f to ab34e01 Compare December 6, 2023 19:08
@jonasrdl
Copy link
Contributor Author

jonasrdl commented Dec 6, 2023

Thanks for the hint @jmhbnz all should be updated now :)

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on workflow green - Thanks @jonasrdl

@ahrtr
Copy link
Member

ahrtr commented Dec 6, 2023

Please also update the changelog for both 3.4 and 3.5. Thanks.

@ahrtr ahrtr merged commit 39b440c into etcd-io:release-3.4 Dec 6, 2023
12 checks passed
@jonasrdl jonasrdl deleted the release-3.4-update-to-go-1.21.5 branch December 7, 2023 14:28
@jonasrdl
Copy link
Contributor Author

jonasrdl commented Dec 7, 2023

@ahrtr should I edit it here https://github.com/etcd-io/etcd/blob/main/CHANGELOG/CHANGELOG-3.4.md?plain=1#L23 ? Or add a new section for a new patch version (3.4.29?)

@ahrtr
Copy link
Member

ahrtr commented Dec 7, 2023

@ahrtr should I edit it here https://github.com/etcd-io/etcd/blob/main/CHANGELOG/CHANGELOG-3.4.md?plain=1#L23 ? Or add a new section for a new patch version (3.4.29?)

3.4.28 is already out. Please add a new section for 3.4.29, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants