[3.4] Backport: non mutating requests pass through quotaKVServer when NOSPACE #14254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you mind follow the instruction how to fix DCO failure?
Try |
|
@ramses Thanks for the PR, please signoff the commit, |
No worry, I will take care of the CHANGELOG myself later. |
This is a backport of etcd-io#13435 and is part of the work for 3.4.20 etcd-io#14232. The original change had a second commit that modifies a changelog file. The 3.4 branch does not include any changelog file, so that part was not cherry-picked. Local Testing: - `make build` - `make test` Both succeed. Signed-off-by: Ramsés Morales <ramses@gmail.com>
|
Thanks @chaochn47 and @ahrtr . |
ahrtr
changed the title
ahrtr
approved these changes
Jul 22, 2022
|
it's minor and accordingly safe change, so merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #13435 and is
part of the work for 3.4.20
#14232.
The original change had a second commit that modifies a changelog file.
The 3.4 branch does not include any changelog file, so that part was not
cherry-picked.
Local Testing:
make buildmake testBoth succeed.
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.