Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server/etcdmain: officially supports "arm64" #12929

Merged
merged 1 commit into from
May 11, 2021

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented May 8, 2021

@gyuho gyuho added the WIP label May 8, 2021
@codecov-commenter
Copy link

codecov-commenter commented May 8, 2021

Codecov Report

Merging #12929 (5269b1e) into master (aeb9b5f) will decrease coverage by 0.21%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12929      +/-   ##
==========================================
- Coverage   73.23%   73.01%   -0.22%     
==========================================
  Files         430      430              
  Lines       34182    34185       +3     
==========================================
- Hits        25032    24959      -73     
- Misses       7218     7288      +70     
- Partials     1932     1938       +6     
Flag Coverage Δ
all 73.01% <100.00%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/etcdmain/etcd.go 43.91% <100.00%> (+0.57%) ⬆️
server/etcdserver/api/rafthttp/peer.go 77.41% <0.00%> (-18.07%) ⬇️
server/etcdserver/api/rafthttp/peer_status.go 89.28% <0.00%> (-10.72%) ⬇️
client/pkg/v3/tlsutil/tlsutil.go 83.33% <0.00%> (-8.34%) ⬇️
server/etcdserver/api/v3rpc/lease.go 74.64% <0.00%> (-5.64%) ⬇️
server/proxy/grpcproxy/watch.go 93.86% <0.00%> (-3.69%) ⬇️
server/etcdserver/api/v3rpc/util.go 67.85% <0.00%> (-3.58%) ⬇️
client/pkg/v3/testutil/recorder.go 76.27% <0.00%> (-3.39%) ⬇️
client/v3/experimental/recipes/key.go 72.13% <0.00%> (-3.28%) ⬇️
server/etcdserver/api/v3rpc/watch.go 84.67% <0.00%> (-2.92%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aeb9b5f...5269b1e. Read the comment docs.

@gyuho
Copy link
Contributor Author

gyuho commented May 8, 2021

/cc @mkumatag @spzala

Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants