github action: add ARM64 test #12928
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12928 +/- ##
==========================================
- Coverage 73.28% 73.03% -0.25%
==========================================
Files 430 430
Lines 34182 34182
==========================================
- Hits 25051 24966 -85
- Misses 7202 7279 +77
- Partials 1929 1937 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
|
||
| ### Step 2. Install github action on the host | ||
|
|
||
| SSH into the instance, and install the github action self-hosted runner (see [install scripts](https://github.com/etcd-io/etcd/settings/actions/runners/new?arch=arm64&os=linux)). |
There was a problem hiding this comment.
I cannot open the link (404). Please double check / document the permissions needed.
There was a problem hiding this comment.
Just gave you the admin access. Can you check again?
There was a problem hiding this comment.
Still does not work. I cannot open even: https://github.com/etcd-io/etcd/settings
There was a problem hiding this comment.
@ptabor Just added you to cncf-admins. Now you should have access to the settings.
| And run: | ||
|
|
||
| ``` | ||
| # run this as systemd service |
There was a problem hiding this comment.
could you please provide an examplar systemd *.conf file ?
There was a problem hiding this comment.
Leave it as TODO. We will follow up with the example config file.
There was a problem hiding this comment.
Actually, no need to add systemd service file. Github action has built-in script to do that:
sudo ./svc.sh install
sudo ./svc.sh start
sudo ./svc.sh status
Updated the README.
gyuho
force-pushed
the
github-worker-arm64
branch
2 times, most recently
from
ac5dbd5
to
76c4889
Compare
gyuho
force-pushed
the
github-worker-arm64
branch
3 times, most recently
from
5ba2919
to
acf0f8c
Compare
scripts/update_dep.sh
Outdated
| @@ -15,7 +15,7 @@ mod="$1" | |||
| ver="$2" | |||
|
|
|||
| function maybe_update_module { | |||
| log_callout "Processing ${module}" | |||
| log_callout "Processing ${mod}" | |||
There was a problem hiding this comment.
Fixing the shellcheck error. It was failing due to unassigned var.
There was a problem hiding this comment.
It was piggy-backing on the variable set here:
Line 159 in 5f6f69c
with the intent of printing module that we are currently processing.
Lets remove the line at all.
README for self-hosted-linux-arm64-graviton2-tests.yml Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
gyuho
force-pushed
the
github-worker-arm64
branch
from
6ee8249
to
3a04b2b
Compare
Tested in my personal fork:
ref. #12856 and etcd-io/website#273