etcdctl: fix member add command #11194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm, defer to @jpbetz Also, can we add a TODO to handle stale member list response, in server side? Ideally, this should be handled in server side. |
I opened #11198 to track this. |
|
Implemented as I had expected LGTM |
This was referenced Oct 3, 2019
jingyih
added a commit
to jingyih/etcd
that referenced
this pull request
Oct 3, 2019
jingyih
added a commit
to jingyih/etcd
that referenced
this pull request
Oct 3, 2019
gyuho
added a commit
that referenced
this pull request
Oct 3, 2019
…4-origin-release-3.4 Automated cherry pick of #11194 on release-3.4
gyuho
added a commit
that referenced
this pull request
Oct 3, 2019
…4-origin-release-3.3 Automated cherry pick of #11194 on release-3.3
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11186.