Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.4] Test failure: "Too many goroutines running after all test" #14159

Closed
ahrtr opened this issue Jun 24, 2022 · 6 comments
Closed

[3.4] Test failure: "Too many goroutines running after all test" #14159

ahrtr opened this issue Jun 24, 2022 · 6 comments

Comments

@ahrtr
Copy link
Member

ahrtr commented Jun 24, 2022

We are going to release 3.4.19, and the top priority is to make the pipeline as stable as possible.

Too many goroutines running after all test(s).
1 instances of:
go.etcd.io/etcd/etcdserver/api/v3rpc.(*serverWatchStream).recvLoop(...)
	/home/runner/work/etcd/etcd/etcdserver/api/v3rpc/watch.go:336 +0x214
go.etcd.io/etcd/etcdserver/api/v3rpc.(*watchServer).Watch.func2(...)
	/home/runner/work/etcd/etcd/etcdserver/api/v3rpc/watch.go:190 +0x45
created by go.etcd.io/etcd/etcdserver/api/v3rpc.(*watchServer).Watch
	/home/runner/work/etcd/etcd/etcdserver/api/v3rpc/watch.go:189 +0x2ec
FAIL	go.etcd.io/etcd/clientv3/integration	270.490s
FAIL

Refer to https://github.com/etcd-io/etcd/runs/7049120619?check_suite_focus=true

@lavacat
Copy link

lavacat commented Jun 30, 2022

/assign

@ahrtr
Copy link
Member Author

ahrtr commented Jul 8, 2022

@lavacat Do you have any update on this ticket?

@lavacat
Copy link

lavacat commented Jul 8, 2022

no updates yet, only looked at the other one

@lavacat
Copy link

lavacat commented Jul 28, 2022

I wasn't able to reproduce this and I went through GitHub Actions runs for ~10days and didn't see this error. The most relevant comment about similar issue here

I think there might be 'false negatives', i.e. situation when goroutine is 'RUNNING' (not waiting), so its not reported by list of goroutines, so we might exit leak detection when there is actually a goroutine leaked. But it should not be reported as failure.

I suggest we close this out

@ahrtr
Copy link
Member Author

ahrtr commented Jul 28, 2022

Thanks, let's reopen it once we see it again.

@ahrtr ahrtr closed this as completed Jul 28, 2022
@MadhavJivrajani
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants