Skip to content

Issue 221: add type(), size() and dimensions() to Selection class #545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jkotan merged 3 commits into from
Dec 14, 2021
Merged

Issue 221: add type(), size() and dimensions() to Selection class #545

jkotan merged 3 commits into from
Dec 14, 2021

Conversation

@jkotan
Copy link
Collaborator

@jkotan jkotan commented Dec 13, 2021

It resolves #221 by adding virtual type(), size() and dimensions() methods to Selection class and implementing them in Hyperslab and Points classes.

yuelongyu
yuelongyu reviewed Dec 14, 2021
View reviewed changes
@jkotan jkotan requested a review from yuelongyu December 14, 2021 10:18
yuelongyu
yuelongyu approved these changes Dec 14, 2021
View reviewed changes
Copy link
Collaborator

@yuelongyu yuelongyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@jkotan jkotan merged commit 5171670 into master Dec 14, 2021
@jkotan jkotan deleted the issue_221 branch December 14, 2021 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yuelongyu yuelongyu yuelongyu approved these changes

@eugenwintersberger eugenwintersberger Awaiting requested review from eugenwintersberger

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improvements to the general Selection interface

3 participants

@jkotan @yuelongyu