Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add monitor timestamp settings (VSC-1130) #989

Merged
merged 2 commits into from
Jun 29, 2023

Conversation

boarchuz
Copy link
Contributor

Description

Adds settings to enable and customise timestamps in IDF Monitor.

Closes #975

Type of change

  • New feature (non-breaking change which adds functionality)

Steps to test this pull request

  1. Open VS Code settings
  2. Alter monitorEnableTimestamps and/or monitorCustomTimestampFormat (eg. %Y-%m-%d %H:%M:%S)
  3. Open IDF Monitor with an actively transmitting device attached and confirm that timestamps are appended and formatted as expected.

How has this been tested?

Tested by opening IDF Monitor in an existing project, with ESP32 attached and transmitting over UART, and confirming expected behaviour with timestamps enabled, disabled, and with multiple format strings.

Test Configuration:

  • ESP-IDF Version: master (1.6.3)
  • OS (Windows,Linux and macOS): Linux (Ubuntu)

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

@brianignacio5
Copy link
Collaborator

HI @boarchuz thank you for your PR sorry I haven't had the time to make it myself.

Could you run yarn lint locally and use the Format document command in vscode to fix the lint issues ?

@github-actions github-actions bot changed the title Add monitor timestamp settings Add monitor timestamp settings (VSC-1130) Jun 16, 2023
@boarchuz
Copy link
Contributor Author

No worries, @brianignacio5, the changes seemed fairly straight-forward so I had a go myself. If you had something else in mind, feel free to ignore this, I just really want timestamps supported.
Formatting is now fixed.

@brianignacio5
Copy link
Collaborator

Oh by the way @boarchuz I've noticed that this --timestamps argument was implemented in ESP-IDF v4.4 so we also need to add a validation for ESP-IDF version to avoid execution issues.

@brianignacio5 brianignacio5 added this to the 1.6.4 milestone Jun 29, 2023
@brianignacio5 brianignacio5 merged commit 0758485 into espressif:master Jun 29, 2023
@boarchuz
Copy link
Contributor Author

we also need to add a validation for ESP-IDF version to avoid execution issues.

Sorry for not getting to this sooner, thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Enable timestamps in IDF Monitor (VSC-1112)
2 participants