Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add container user to dialout group #944

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

brianignacio5
Copy link
Collaborator

Description

Add container user to dialout to allow serial port access.

Fix #942

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Steps to test this pull request

Provide a list of steps to test changes in this PR and required output

  1. Start VS Code, run the Dev Containers: Open Folder in Container... command from the Command Palette (F1) or quick actions Status bar item, and select the project folder you would like to set up the container for.
  2. Run ESP-IDF Monitor and see if it works.
  • Expected behaviour: Monitor starts working correctly. No Permission denied: '/dev/ttyUSB0' errors

  • Expected output: Normal IDF Monitor output

How has this been tested?

Tested by manual run of container blink ESP-IDF example.

Test Configuration:

  • ESP-IDF Version: 5.1
  • OS (Windows,Linux and macOS): macOS

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

@brianignacio5 brianignacio5 added the bugfix Fixing some issue and bug in this PR label Apr 19, 2023
@brianignacio5 brianignacio5 self-assigned this Apr 19, 2023
@github-actions
Copy link

Download the artifacts for this pull request:

Copy link
Collaborator

@radurentea radurentea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brianignacio5 brianignacio5 merged commit ddc4be4 into master Apr 28, 2023
@brianignacio5 brianignacio5 deleted the bugfix/container-user-dialout-group branch April 28, 2023 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixing some issue and bug in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

non-root user devcontainer has no permission to access ttyUSB* (VSC-1093)
2 participants