-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validation for existing setup path #1228
Conversation
Download the artifacts for this pull request: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments but otherwise LGTM
This should not be tested yet. New improvements were requested by Kondal and I'm currently working on implementing them. |
All changes are done, can be tested |
@radurentea hi ! Tested under: tested with multiple esp-idf folders, do see validation ✔️ But there is a small issue with validation: |
@AndriiFilippov Thank you, I've fixed the issue. When you have time please test it again |
- Reverted order for template and script - Used canAccessFile instead of newly created function checkFileExists
e23c752
to
43e8d81
Compare
@radurentea hi ! good 👍 validation should works only for existing ESP-IDF folder. |
Not validating folder if version is not selected
@radurentea hi ! everything works ✔️ |
Hi Andrii, we've discussed this before the implementation and we agreed on this. We can't make it real time because there will be to many calls |
Hi @brianignacio5, PTAL again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @brianignacio5, please take another look with the new updates. I've tested on Mac and I couldn't not reproduce the error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on MacOS and the previous issue doesn't happen anymore.
LGTM
Hi @AndriiFilippov, please test when you have a moment. |
@radurentea hi ! Tested under: LGTM 👍 |
Description
Added validation for esp-idf path, when user selects "Find ESP-IDF in your system" while configuring the extension.
Jira: VSC-1174
Type of change
Steps to test this pull request
How has this been tested?
As described above
Test Configuration:
Checklist