Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update application insights ID #1069

Merged
merged 1 commit into from
Nov 2, 2023
Merged

update application insights ID #1069

merged 1 commit into from
Nov 2, 2023

Conversation

igrr
Copy link
Member

@igrr igrr commented Oct 30, 2023 •
edited
Loading

Description

Update the Application Insights ID to point to the new subscription.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Steps to test this pull request

Build the extension from this branch, run it. Verify that some records appear in Azure console.

How has this been tested?

I have built the VSIX package, installed it, ran a few actions with IDF extension. Have checked that some events have appeared in Azure console:

(log)
timestamp [UTC] name client_OS client_CountryOrRegion
10/30/2023, 4:04:12.057 PM espressif.esp-idf-extension/command Darwin 22.6.0 Czechia
10/30/2023, 4:06:15.584 PM espressif.esp-idf-extension/command Darwin 22.6.0 Czechia
10/30/2023, 4:04:11.857 PM espressif.esp-idf-extension/command Darwin 22.6.0 Czechia
10/30/2023, 4:06:53.861 PM espressif.esp-idf-extension/command Darwin 22.6.0 Czechia
10/30/2023, 4:08:21.661 PM espressif.esp-idf-extension/command Linux 6.2.0-1015-azure United States
10/30/2023, 4:08:21.730 PM espressif.esp-idf-extension/command Linux 6.2.0-1015-azure United States
10/30/2023, 4:10:17.109 PM espressif.esp-idf-extension/command Linux 6.2.0-1015-azure United States
10/30/2023, 4:10:19.523 PM espressif.esp-idf-extension/command Darwin 22.6.0 Czechia
10/30/2023, 4:10:30.039 PM espressif.esp-idf-extension/command Darwin 22.6.0 Czechia
10/30/2023, 4:11:23.776 PM espressif.esp-idf-extension/command Darwin 22.6.0 Czechia
10/30/2023, 4:11:33.210 PM espressif.esp-idf-extension/command Darwin 22.6.0 Czechia
10/30/2023, 4:04:12.280 PM espressif.esp-idf-extension/command Darwin 22.6.0 Czechia
10/30/2023, 4:05:56.127 PM espressif.esp-idf-extension/command Darwin 22.6.0 Czechia
10/30/2023, 4:07:35.929 PM espressif.esp-idf-extension/command Darwin 22.6.0 Czechia

Dependent components impacted by this PR:

None

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

@github-actions
Copy link

Download the artifacts for this pull request:

brianignacio5
brianignacio5 approved these changes Nov 1, 2023
View reviewed changes
Copy link
Collaborator

@brianignacio5 brianignacio5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@igrr
Copy link
Member Author

igrr commented Nov 2, 2023

@brianignacio5 Could we merge this?

@brianignacio5 brianignacio5 merged commit 0706210 into master Nov 2, 2023
6 checks passed
@brianignacio5 brianignacio5 deleted the change/update_telemetry_id branch November 2, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianignacio5 brianignacio5 brianignacio5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@igrr @brianignacio5