Skip to content

feat(mdns): support null value for boolean txt records #822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tanyanquan
Copy link
Contributor

@tanyanquan tanyanquan commented Jun 12, 2025

Description

This PR adds support for NULL values to be used in mdns txt records in order to differentiate "myKey" and "myKey=" txt records.

These two records are considered to be different in RFC 6763 Section 6.4, so it is important for us to have a way to handle them differently.

Previous usage (if NULL is not supported):
"myKey" -> key = "myKey", value = ""; "myKey=" -> key = "myKey", value = ""

Suggested changes:
"myKey" -> key = "myKey", value = NULL; "myKey=" -> key = "myKey", value = ""

Related

Testing


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@tanyanquan tanyanquan force-pushed the feat/support_null_value_txt branch from 5843669 to 9a9861d Compare June 12, 2025 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant