Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bootloader_support): Add missing C linkage to some headers (IDFGH-12930) #13890

Conversation

andylinpersonal
Copy link
Contributor

@andylinpersonal andylinpersonal commented Jun 1, 2024

I'm developing some bootloader hooks in C++ and just found some headers lack extern "C" {} guard.
This issue can also be found in release/v5.3 and master.

Copy link

github-actions bot commented Jun 1, 2024

Fails
🚫
    The target branch for this pull request should be `master`.

    If you would like to add this feature to the release branch, please state this in the PR description and we will consider backporting it.

👋 Welcome andylinpersonal, thank you for your first contribution to espressif/esp-idf project!

📘 Please check Contributions Guide for the contribution checklist, information regarding code and documentation style, testing and other topics.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for espressif/esp-idf project.

Pull request review and merge process you can expect

Espressif develops the ESP-IDF project in an internal repository (Gitlab). We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

  1. An internal issue has been created for the PR, we assign it to the relevant engineer
  2. They review the PR and either approve it or ask you for changes or clarifications
  3. Once the Github PR is approved, we synchronize it into our internal git repository
  4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing
    • At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
  5. If the change is approved and passes the tests it is merged into the master branch
  6. On next sync from the internal git repository merged change will appear in this public Github repository

🔁 You can re-run automatic PR checks by retrying the DangerJS action

Generated by 🚫 dangerJS against 6088b3d

andylinpersonal added a commit to andylinpersonal/esp-idf that referenced this pull request Jun 1, 2024
@andylinpersonal andylinpersonal force-pushed the dev/fix-missing-extern-c branch from dce5d1c to e9b2cb6 Compare June 1, 2024 15:40
@andylinpersonal andylinpersonal marked this pull request as draft June 1, 2024 15:46
@andylinpersonal andylinpersonal force-pushed the dev/fix-missing-extern-c branch from e9b2cb6 to 6088b3d Compare June 1, 2024 15:49
@andylinpersonal andylinpersonal marked this pull request as ready for review June 1, 2024 15:52
@espressif-bot espressif-bot added the Status: Opened Issue is new label Jun 1, 2024
@github-actions github-actions bot changed the title fix(bootloader_support): Add missing c linkage to some headers fix(bootloader_support): Add missing c linkage to some headers (IDFGH-12930) Jun 1, 2024
@andylinpersonal andylinpersonal changed the title fix(bootloader_support): Add missing c linkage to some headers (IDFGH-12930) fix(bootloader_support): Add missing C linkage to some headers (IDFGH-12930) Jun 1, 2024
@KonstantinKondrashov
Copy link
Collaborator

Hi @andylinpersonal!
Seems like we can take these changes to master. Backports will not be created though because it is not a critical issue.
I see that you made some changes. Is it the final version?
Have you achieved your goal with these changes? Ok, anyway I will check the rest bootloader headers if it is needed there as well.

@andylinpersonal
Copy link
Contributor Author

Oh it's the final version. I've just removed some accidentally re-formatted code.

@espressif-bot espressif-bot added Status: Reviewing Issue is being reviewed Status: Done Issue is done internally Resolution: NA Issue resolution is unavailable and removed Status: Opened Issue is new Status: Reviewing Issue is being reviewed labels Jun 4, 2024
@andylinpersonal
Copy link
Contributor Author

Fixed in 788455f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants