-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(bootloader_support): Add missing C linkage to some headers (IDFGH-12930) #13890
fix(bootloader_support): Add missing C linkage to some headers (IDFGH-12930) #13890
Conversation
👋 Welcome andylinpersonal, thank you for your first contribution to 📘 Please check Contributions Guide for the contribution checklist, information regarding code and documentation style, testing and other topics. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for espressif/esp-idf project. Pull request review and merge process you can expectEspressif develops the ESP-IDF project in an internal repository (Gitlab). We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.
🔁 You can re-run automatic PR checks by retrying the DangerJS action |
dce5d1c
to
e9b2cb6
Compare
e9b2cb6
to
6088b3d
Compare
Hi @andylinpersonal! |
Oh it's the final version. I've just removed some accidentally re-formatted code. |
Fixed in 788455f |
I'm developing some bootloader hooks in C++ and just found some headers lack
extern "C" {}
guard.This issue can also be found in
release/v5.3
andmaster
.