ESP-IDF v5.1 #7733

me-no-dev · 2023-01-19T20:54:24Z

This is very much work in progress. For now it's used only to update everything necessary and use the CI.

Changes that need to be done:

Replace all FreeRTOS handles to the new API to allow running as component when compatibility is disabled
Refactor platform.txt to not use components installed through the board manager when running from git
Create Peripheral Manager to keep track of bus drivers and pins

Warnings left to be fixed:

ESP-IDF Driver Deprecations

ADC

In file included from cores/esp32/esp32-hal-adc.c:16:
tools/sdk/esp32/include/driver/deprecated/driver/adc.h:19
   19 | #warning "legacy adc driver is deprecated, please migrate to use esp_adc/adc_oneshot.h and esp_adc/adc_continuous.h for oneshot mode and continuous mode drivers respectively"
      |  ^~~~~~~

In file included from cores/esp32/esp32-hal-adc.c:17:
tools/sdk/esp32/include/esp_adc/deprecated/include/esp_adc_cal.h:17
   17 | #warning "legacy adc calibration driver is deprecated, please migrate to use esp_adc/adc_cali.h and esp_adc/adc_cali_scheme.h"
      |  ^~~~~~~

DAC

In file included from cores/esp32/esp32-hal-dac.c:22:
tools/sdk/esp32/include/driver/deprecated/driver/dac.h:16
   16 | #warning "The legacy DAC driver is deprecated, please use `driver/dac_oneshot.h`, `driver/dac_cosine.h` or `driver/dac_continuous.h` instead"
      |  ^~~~~~~

RMT

In file included from cores/esp32/esp32-hal-rmt.c:16:
tools/sdk/esp32/include/driver/deprecated/driver/rmt.h:18
   18 | #warning "The legacy RMT driver is deprecated, please use driver/rmt_tx.h and/or driver/rmt_rx.h"
      |  ^~~~~~~

Sigma Delta

In file included from cores/esp32/esp32-hal-sigmadelta.c:19:
tools/sdk/esp32/include/driver/deprecated/driver/sigmadelta.h:15
   15 | #warning "The legacy sigma-delta driver is deprecated, please use driver/sdm.h"
      |  ^~~~~~~

HW Timer

In file included from cores/esp32/esp32-hal-timer.c:16:
tools/sdk/esp32/include/driver/deprecated/driver/timer.h:16
   16 | #warning "legacy timer group driver is deprecated, please migrate to driver/gptimer.h"
      |  ^~~~~~~

I2S

In file included from tools/sdk/esp32/include/driver/deprecated/driver/i2s.h:23,
                 from libraries/I2S/src/I2S.h:26:
tools/sdk/esp32/include/driver/deprecated/driver/adc.h:19
   19 | #warning "legacy adc driver is deprecated, please migrate to use esp_adc/adc_oneshot.h and esp_adc/adc_continuous.h for oneshot mode and continuous mode drivers respectively"
      |  ^~~~~~~

In file included from libraries/I2S/src/I2S.h:26:
tools/sdk/esp32/include/driver/deprecated/driver/i2s.h:27
   27 | #warning "This set of I2S APIs has been deprecated, please include 'driver/i2s_std.h', 'driver/i2s_pdm.h' or 'driver/i2s_tdm.h' instead.
      |  ^~~~~~~

libraries/I2S/src/I2S.cpp:148
  148 |     #warning The following values are new and need to be checked
      |      ^~~~~~~

I2S Example

In file included from tools/sdk/esp32/include/driver/deprecated/driver/i2s.h:23,
                 from libraries/ESP32/examples/I2S/HiFreq_ADC/HiFreq_ADC.ino:23:
tools/sdk/esp32/include/driver/deprecated/driver/adc.h:19
   19 | #warning "legacy adc driver is deprecated, please migrate to use esp_adc/adc_oneshot.h and esp_adc/adc_continuous.h for oneshot mode and continuous mode drivers respectively"
      |  ^~~~~~~

In file included from libraries/ESP32/examples/I2S/HiFreq_ADC/HiFreq_ADC.ino:23:
tools/sdk/esp32/include/driver/deprecated/driver/i2s.h:27
   27 | #warning "This set of I2S APIs has been deprecated, please include 'driver/i2s_std.h', 'driver/i2s_pdm.h' or 'driver/i2s_tdm.h' instead.
      |  ^~~~~~~

Upstream warnings that can not be silenced

Insights

In file included from tools/sdk/esp32/include/esp_insights/include/esp_insights.h:18,
                 from libraries/Insights/src/Insights.cpp:8:
tools/sdk/esp32/include/esp_diagnostics/include/esp_diagnostics.h:241:29: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]
  241 |     esp_diag_log_event(tag, "EV (%"PRIu32") %s: " format, esp_log_timestamp(), tag, ##__VA_ARGS__); \
      |

* Added the example guideline and template * PR review changes with some typos and grammar fixes * Changes according to the PR review

VojtechBartoska · 2023-01-23T13:32:28Z

To-Do list till Wednesday 25.1.:

@SuGlider & @P-R-O-C-H-Y - please check related drivers and think about possible approach for porting them
- @P-R-O-C-H-Y can handle ADC, DAC, SigmaDelta and Timer
- @SuGlider can handle RMT and I2S
@PilnyTomas - please check out this branch and update new toolchain and test WiFI & Bluetooth (run some examples)

SuGlider · 2023-01-24T00:23:12Z

RMT Report

All the Arduino ESP32 RMT examples compiled and worked as expected using ESP32 and ESP32C3 (using IDF 5.1 Legacy Driver)

New IDF 5.1 RMT is quite different when compared with IDF 4.4 (which has the same API as the IDF 5.1 Legacy Driver)
Refactoring RMT to use new API from IDF 5.1 will demand some effort and time.

P-R-O-C-H-Y · 2023-01-24T11:07:23Z

Report from peripherals testing:

ADC:

Found BUG analogRead -> line 178 (return) is wrong, should be 0 because error occured (not related to IDF 5.x)
ADC not working on all chips using IDF 5.1 legacy driver
New ADC driver, split ADC source files to Continuous / OneShot, refactoring needed.
side note for migration guide - Hall sensor read REMOVED from IDF 5.X (Hristo removed that already)

DAC:

DAC tested using IDF 5.1 legacy driver, working on ESP32 but broken on ESP32-S2
new DAC driver have been redesigned, need to be refactored.

Sigma-Delta:

Example compiled and working using IDF 5.1 legacy driver
Tested on ESP32, ESP32-C3, ESP32-S2 and ESP32-S3
New SigmaDelta driver have new API, refactoring is needed (not that complicated)

Timer:

HW test compiled and working using IDF 5.1 legacy driver
Tested on ESP32, pytest seems to not work properly, compiling working on all chips, but running test doesn’t accept other chips than ESP32
New Timer driver (GPTimer) have new API, refactoring is needed
New driver seems to be allowed to run within ISR context (should fix some related issues)

PilnyTomas · 2023-01-24T13:15:11Z

* update tests requirements * remove already handled components * Update version of pytest * Add missing ESP32-H2 to hil.yml

* add C6/H2 to tests cfg.json * remove , * workflow runs-on runner by matrix * Add need for arduino tag to select runner * Add cryptography to requirements.txt

hansmbakker · 2023-07-18T18:12:03Z

Hi! I’m really looking forward to this new version of arduino-esp32! Is there any indication on when we can start trying it?

me-no-dev · 2023-07-18T18:18:29Z

Hi! I’m really looking forward to this new version of arduino-esp32! Is there any indication on when we can start trying it?

you can start now if you install it through github. Just make sure you pull the correct branch and then execute tools/get.exe or tools/get.py

* Fixes Filter and Idle parameter to uint32 * Fixes Filter and Idle setup * Fixes it to 5.1Libs branch * fix RMT CLK source and Filter API * fixes missing ; * fixes missing ; * fixes RMT example

* Add workflow to build executables from python scripts * Push binary to tools * Enable executable signing on Windows * Update get.py * Push binary to tools * Try with multiple files * Try more actions * Try powershell * Restore tools so they do not get rebuilt * Finalize scripts * Push binary to tools

…ntation. Previous pin use works but is inconsistent with C6 docs.

* fixes preprocessor test When using `#define USE_SOFT_AP` Change `&& not USE_SOFT_AP` ==> `&& !defined(USE_SOFT_AP)` * Adds any BLE capable device in WiFiProv.ino Removing ESP32 restriction for BLE Provisioning.

fix flash mode read out for C6

Fixing UART1 pins for esp-idf-v5.1-libs

* Updated SD_MMC lib and examples * Removed getter implementation and commented usage in examples * squashed updates

me-no-dev and others added 22 commits January 19, 2023 18:39

Initial changes to compile under ESP-IDF v5.1

c6feed9

Initial import for ESP-IDF v5.1 libs

43845da

Update toolchain

8ea62bb

Update esp32-hal-psram.c

9802cf9

Add missing LDs

d006d83

Update platform.txt

b9c6eff

Stop some CI jobs, because they will always fail

486840f

Fix examples

04a7a18

Update app_httpd.cpp

eab71b9

Update ResetReason.ino

bb20ee9

Warnings fixes

a9df6ba

Added the example guideline and template (#7665)

32807bb

* Added the example guideline and template * PR review changes with some typos and grammar fixes * Changes according to the PR review

Added ESP32-S3 link to the datasheet (#7738)

ea75f3e

Update HiFreq_ADC.ino

dca2c03

Replace periph_ctrl.h use because of deprecation

fd3c28d

Replace esp_spi_flash.h use because of deprecation

c0c4db6

Add includes to male mDNS::enableWorkstation compile

67e71bb

Fix ssl_client mbedtls_pk_parse_key callback

bce5d87

Update temperature sensor driver

449171c

Allow sketch_utils to compile with arduino-cli

84008e3

Run CI with arduino-cli

e2c8042

Fix arduino-cli CI build on Windows

5358014

VojtechBartoska added this to the 3.0.0 milestone Jan 23, 2023

VojtechBartoska added Area: ESP-IDF related ESP-IDF related issues Type: CI & Testing labels Jan 23, 2023

VojtechBartoska added the Status: In Progress Issue is in progress label Jan 23, 2023

me-no-dev and others added 7 commits July 4, 2023 10:45

ESP32-C3 does not have ets_write_char_uart

f8c5b98

Fix BLE gap event name

3246baa

HW Testing - Pytest update (#8389)

431bf8b

* update tests requirements * remove already handled components * Update version of pytest * Add missing ESP32-H2 to hil.yml

Updated FreeRTOS names (#8418)

4a12dba

HW Testing - ESP32-C6 + ESP32-H2 fixes (#8404)

c088bcf

* add C6/H2 to tests cfg.json * remove , * workflow runs-on runner by matrix * Add need for arduino tag to select runner * Add cryptography to requirements.txt

Removed duplicate TX1 define for H2 (#8402)

9aeed61

Merge branch 'master' into esp-idf-v5.1-libs

f4cfacd

Fix broken examples

065ced1

SuGlider and others added 18 commits July 20, 2023 12:31

Fixes RMT filter & idle timing and setup (#8359)

3162e94

* Fixes Filter and Idle parameter to uint32 * Fixes Filter and Idle setup * Fixes it to 5.1Libs branch * fix RMT CLK source and Filter API * fixes missing ; * fixes missing ; * fixes RMT example

IDF release/v5.1 a7b62bbcaf (#8438)

8cf6294

App rollback should be after PSRAM is initialized

5a6507e

Correcting RX1 to GPIO4 and TX1 to GPIO5 to be consistent with docume…

bfab4fe

…ntation. Previous pin use works but is inconsistent with C6 docs.

Merge branch 'master' into esp-idf-v5.1-libs

17e1ad5

Fixes Memory Leak (#8486)

e9f4572

fixes preprocessor test (#8485)

9d3fa6b

* fixes preprocessor test When using `#define USE_SOFT_AP` Change `&& not USE_SOFT_AP` ==> `&& !defined(USE_SOFT_AP)` * Adds any BLE capable device in WiFiProv.ino Removing ESP32 restriction for BLE Provisioning.

fix flash mode read out for C6

d663575

Merge pull request #8517 from Jason2866/esp-idf-v5.1-libs-1

90978c8

fix flash mode read out for C6

Merge pull request #8477 from Proofzy/esp-idf-v5.1-libs-uart1-pins

b4f5e65

Fixing UART1 pins for esp-idf-v5.1-libs

Add option for custom partitions without restrictions

712bca1

SD_MMC update (#8298)

ee9a71d

* Updated SD_MMC lib and examples * Removed getter implementation and commented usage in examples * squashed updates

Merge branch 'master' into esp-idf-v5.1-libs

4fb5a2c

IDF release/v5.1 f0437b945f (#8599)

caddefc

Update package_esp32_index.template.json

388106f

Merge branch 'master' into esp-idf-v5.1-libs

7beab8e

Fix printf format build error in BTAdvertisedDeviceSet.cpp

21b6456

me-no-dev merged commit 6f7a1ca into master Oct 5, 2023
41 checks passed

sgryphon mentioned this pull request Jan 14, 2024

Support Arduino ESP32 v3.0 based on ESP-IDF v5.1 platformio/platform-espressif32#1225

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ESP-IDF v5.1 #7733

ESP-IDF v5.1 #7733

me-no-dev commented Jan 19, 2023 •

edited

Loading

VojtechBartoska commented Jan 23, 2023 •

edited

Loading

SuGlider commented Jan 24, 2023

P-R-O-C-H-Y commented Jan 24, 2023 •

edited

Loading

PilnyTomas commented Jan 24, 2023 •

edited

Loading

hansmbakker commented Jul 18, 2023 •

edited

Loading

me-no-dev commented Jul 18, 2023

ESP-IDF v5.1 #7733

ESP-IDF v5.1 #7733

Conversation

me-no-dev commented Jan 19, 2023 • edited Loading

This is very much work in progress. For now it's used only to update everything necessary and use the CI.

Changes that need to be done:

Warnings left to be fixed:

ESP-IDF Driver Deprecations

Upstream warnings that can not be silenced

Insights

VojtechBartoska commented Jan 23, 2023 • edited Loading

To-Do list till Wednesday 25.1.:

SuGlider commented Jan 24, 2023

RMT Report

P-R-O-C-H-Y commented Jan 24, 2023 • edited Loading

Report from peripherals testing:

PilnyTomas commented Jan 24, 2023 • edited Loading

hansmbakker commented Jul 18, 2023 • edited Loading

me-no-dev commented Jul 18, 2023

me-no-dev commented Jan 19, 2023 •

edited

Loading

VojtechBartoska commented Jan 23, 2023 •

edited

Loading

P-R-O-C-H-Y commented Jan 24, 2023 •

edited

Loading

PilnyTomas commented Jan 24, 2023 •

edited

Loading

hansmbakker commented Jul 18, 2023 •

edited

Loading