Skip to content

AnalogWrite - frequency and resolution log errors + returns #7471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 8, 2022
Merged

AnalogWrite - frequency and resolution log errors + returns #7471

merged 5 commits into from
Dec 8, 2022

Conversation

P-R-O-C-H-Y
Copy link
Member

Description of Change

To complete previous PR #7346 I have added error messages to our API for all analogWrite functions.
Also added returns, when errors appears to make it work correctly.

Tests scenarios

Tested on ESP32-S3.

Related links

@P-R-O-C-H-Y P-R-O-C-H-Y added the Area: Peripherals API Relates to peripheral's APIs. label Nov 14, 2022
@P-R-O-C-H-Y P-R-O-C-H-Y added this to the 2.0.6 milestone Nov 14, 2022
@P-R-O-C-H-Y P-R-O-C-H-Y self-assigned this Nov 14, 2022
@SuGlider SuGlider merged commit dbeae94 into espressif:master Dec 8, 2022
@P-R-O-C-H-Y P-R-O-C-H-Y deleted the analogWriteResolution-update branch April 19, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@me-no-dev me-no-dev me-no-dev approved these changes

@SuGlider SuGlider SuGlider approved these changes

@PilnyTomas PilnyTomas Awaiting requested review from PilnyTomas

Assignees

@P-R-O-C-H-Y P-R-O-C-H-Y

Labels

Area: Peripherals API Relates to peripheral's APIs.

Projects

Arduino ESP32 Core Project Roadmap
Status: Done

Milestone

2.0.6

Development

Successfully merging this pull request may close these issues.

3 participants

@P-R-O-C-H-Y @me-no-dev @SuGlider