update adafruit boards tinyuf2 and partition scheme #6770
Conversation
platform.txt
Outdated
| build.custom_bootloader=bootloader | ||
| build.custom_partitions=partitions | ||
| build.custom_bootloader= | ||
| build.custom_partitions= |
There was a problem hiding this comment.
This makes the build search for variant/.bin, expanded from "{build.variant.path}"/{build.custom_bootloader}.bin. Maybe it should be left as is?
There was a problem hiding this comment.
yeah, this is meant to expanded to non-existed files by default in the variant/board folder so that one of the espressif default parition csv can be used if an TinyUF2 scheme isn't selected.
There was a problem hiding this comment.
it will still expand to non-existing if you name yours to something else. Default values are there to allow variants to add bootloader.bin and partitions.csv and be done, without having to specify anything in boards.txt. Please rename your bootloaders to something else and the defaults here will work as expected :)
There was a problem hiding this comment.
update PR to revert this changes and rename the bootloader/partition in the variant folder as suggested.
- add tinyuf2 suffix to variant bootloader, cvs - also update adafruit esp32s3 menu to match latest esp32s3dev one
hathach
force-pushed
the
update-adafruit-boards
branch
from
ab8abc6
to
417f45f
Compare
|
Thanks @hathach |
I am the one to say thanks :) |
Description of Change
It address one of the walk-around @UnexpectedMaker need to do is renaming the tinyuf2.bin/bootloader.bin in the variant folder.Tests scenarios
Related links
@ladyada