Skip to content

ADC esp32s2 attenuation fix for DAC pins #6282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 16, 2022
Merged

ADC esp32s2 attenuation fix for DAC pins #6282

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10f3b29
ADC esp32s2 attenuation fix for DAC pins
P-R-O-C-H-Y Feb 14, 2022
cd08cb3
Use soc define instead config target
P-R-O-C-H-Y Feb 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Use soc define instead config target
  • Loading branch information
@P-R-O-C-H-Y
P-R-O-C-H-Y committed Feb 16, 2022
commit cd08cb3b23e003d8a9773bd12ba68812d47673a4
2 changes: 1 addition & 1 deletion cores/esp32/esp32-hal-adc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ bool __adcAttachPin(uint8_t pin){
}
#endif
}
#if CONFIG_IDF_TARGET_ESP32 || CONFIG_IDF_TARGET_ESP32S2
#if SOC_DAC_SUPPORTED
else if(pin == DAC_CHANNEL_1_GPIO_NUM){
CLEAR_PERI_REG_MASK(RTC_IO_PAD_DAC1_REG, RTC_IO_PDAC1_XPD_DAC | RTC_IO_PDAC1_DAC_XPD_FORCE);//stop dac1
} else if(pin == DAC_CHANNEL_2_GPIO_NUM){
Expand Down