Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow using custom linker scripts in PlatformIO build script #3735

Merged
merged 2 commits into from
May 4, 2020
Merged

Allow using custom linker scripts in PlatformIO build script #3735

merged 2 commits into from
May 4, 2020

Conversation

valeros
Copy link
Contributor

@valeros valeros commented Feb 12, 2020

This will allow users to set any linker script from platformio.ini file using the following syntax:

[env:esp32dev]
platform = espressif32
framework = arduino
board = esp32dev
board_build.ldscript = custom_ldscript.ld

This is a more correct way of specifying it in comparison with using the -Wl,-T flag.

@ivankravets
Copy link
Contributor

@me-no-dev Could you merge it?

@valeros valeros changed the title Allow using custom linker scripts Allow using custom linker scripts in PlatformIO build script Feb 12, 2020
@valeros valeros mentioned this pull request Apr 27, 2020
Closed
@szechyjs
Copy link

szechyjs commented May 4, 2020

@me-no-dev any updates on this? the platformio/platform-espressif32 issue above requires this fix.

@me-no-dev me-no-dev merged commit 5d9bb5c into espressif:master May 4, 2020
vvhh2002 pushed a commit to vvhh2002/arduino-esp32 that referenced this pull request Jun 15, 2020
Merge branch 'master' into vvidf/v4.1
acd7320 
* master:
  M5Stack's product offering includes various ESP32-based camera devices. (espressif#4030)
  Fix for issue 3974 m_connectedCount incorrectly decremented when no connection exists
  Add a new board of KITS for IoT education (espressif#3703)
  update M5Camera pins (espressif#4021)
  Update SD_MMC.cpp (espressif#4020)
  Added missing wifi_provisioning dependency. (espressif#4003)
  HardwareSerial bugfix & improvement (espressif#3713)
  Allow using custom linker scripts (espressif#3735)
  Add M5Stack-ATOM Board (espressif#3883)
  Minor modifications in provisioning (espressif#3919)
  Add support of unified provisioning to Arduino
  Update install-platformio-esp32.sh
  add new board Handbit  (espressif#3807)
  Move _STREAM_BOUNDARY before _STREAM_PART (espressif#3720)
  Add Senses's WEIZEN board from Senses IoT platform (espressif#3687)
  Revert "std::shared_ptr Memory Leak (espressif#3680)" (espressif#3682)
  std::shared_ptr Memory Leak (espressif#3680)
  Minimize HardwareSerial Receive and Transmit delays (espressif#3664)
  fix removeApbChangeCallback() error in spiStopBus() (espressif#3675)

# Conflicts:
#	CMakeLists.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivankravets ivankravets Awaiting requested review from ivankravets

@me-no-dev me-no-dev Awaiting requested review from me-no-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@valeros @ivankravets @szechyjs @me-no-dev