Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTA Library adjust #10627

Merged
merged 4 commits into from
Nov 20, 2024
Merged

OTA Library adjust #10627

merged 4 commits into from
Nov 20, 2024

Conversation

SuGlider
Copy link
Collaborator

Description of Change

General revision of OTA Arduino Library.

Tests scenarios

Example using ESP32, ESP32-S3
Testing using CI

Related links

None

@SuGlider SuGlider added the Area: Libraries Issue is related to Library support. label Nov 19, 2024
@SuGlider SuGlider added this to the 3.0.8 milestone Nov 19, 2024
@SuGlider SuGlider self-assigned this Nov 19, 2024
@SuGlider SuGlider added the Status: Review needed Issue or PR is awaiting review label Nov 19, 2024
Copy link
Contributor

github-actions bot commented Nov 19, 2024

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "feat(ota): library revision":
    • summary looks too short
  • the commit message "feat(ota): license addtion":
    • summary looks too short
  • the commit message "feat(ota): license":
    • summary looks too short

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

Messages
📖 You might consider squashing your 4 commits (simplifying branch history).

👋 Hello SuGlider, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 4699b02

Copy link
Contributor

github-actions bot commented Nov 19, 2024

Test Results

 56 files   56 suites   4m 18s ⏱️
 21 tests  21 ✅ 0 💤 0 ❌
134 runs  134 ✅ 0 💤 0 ❌

Results for commit 4699b02.

♻️ This comment has been updated with latest results.

@SuGlider
Copy link
Collaborator Author

@lucasssvaz - The C6 and H2 CI error doesn't seem correct. I can find esp_zigbee_core.h in the arduino libs.

https://github.com/espressif/arduino-esp32/actions/runs/11921252652/job/33224986562?pr=10627
https://github.com/espressif/arduino-esp32/actions/runs/11921252652/job/33224986954?pr=10627

$ find . -name esp_zigbee_core.h -print 2> /dev/null
./tools/esp32-arduino-libs/esp32/include/espressif__esp-zigbee-lib/include/esp_zigbee_core.h
./tools/esp32-arduino-libs/esp32c3/include/espressif__esp-zigbee-lib/include/esp_zigbee_core.h
./tools/esp32-arduino-libs/esp32c6/include/espressif__esp-zigbee-lib/include/esp_zigbee_core.h
./tools/esp32-arduino-libs/esp32h2/include/espressif__esp-zigbee-lib/include/esp_zigbee_core.h
./tools/esp32-arduino-libs/esp32s2/include/espressif__esp-zigbee-lib/include/esp_zigbee_core.h
./tools/esp32-arduino-libs/esp32s3/include/espressif__esp-zigbee-lib/include/esp_zigbee_core.h

@SuGlider SuGlider changed the title Ota library revision OTA Library adjust Nov 19, 2024
@lucasssvaz
Copy link
Collaborator

lucasssvaz commented Nov 19, 2024

@lucasssvaz - The C6 and H2 CI error doesn't seem correct. I can find esp_zigbee_core.h in the arduino libs.

https://github.com/espressif/arduino-esp32/actions/runs/11921252652/job/33224986562?pr=10627
https://github.com/espressif/arduino-esp32/actions/runs/11921252652/job/33224986954?pr=10627

$ find . -name esp_zigbee_core.h -print 2> /dev/null
./tools/esp32-arduino-libs/esp32/include/espressif__esp-zigbee-lib/include/esp_zigbee_core.h
./tools/esp32-arduino-libs/esp32c3/include/espressif__esp-zigbee-lib/include/esp_zigbee_core.h
./tools/esp32-arduino-libs/esp32c6/include/espressif__esp-zigbee-lib/include/esp_zigbee_core.h
./tools/esp32-arduino-libs/esp32h2/include/espressif__esp-zigbee-lib/include/esp_zigbee_core.h
./tools/esp32-arduino-libs/esp32s2/include/espressif__esp-zigbee-lib/include/esp_zigbee_core.h
./tools/esp32-arduino-libs/esp32s3/include/espressif__esp-zigbee-lib/include/esp_zigbee_core.h

Master branch has out of date libs that does not include zigbee. Just ignore this

@me-no-dev me-no-dev added Status: Pending Merge Pull Request is ready to be merged and removed Status: Review needed Issue or PR is awaiting review labels Nov 20, 2024
@me-no-dev me-no-dev merged commit f0ded24 into master Nov 20, 2024
60 of 73 checks passed
@me-no-dev me-no-dev deleted the ota_library_revision branch November 20, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Libraries Issue is related to Library support. Status: Pending Merge Pull Request is ready to be merged
Projects
Development

Successfully merging this pull request may close these issues.

3 participants