Skip to content

feat(kconfig): Add option to kconfig #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

feat(kconfig): Add option to kconfig #221

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion components/esptool_py/Kconfig.projbuild
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,8 @@ choice ESPTOOLPY_FLASHSIZE
help
SPI flash size, in megabytes

config ESPTOOLPY_FLASHSIZE_1MB
bool "1 MB"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modification for 1MB is not related with this PR.

Maybe we will not recommend to use 1MB flash, since the binary size is increased, and maybe larger than 512KB, 1MB flash cannot support OTA.

config ESPTOOLPY_FLASHSIZE_2MB_C1
bool "2 MB"
config ESPTOOLPY_FLASHSIZE_4MB_C1
Expand All @@ -115,6 +117,7 @@ endchoice

config ESPTOOLPY_FLASHSIZE
string
default "1MB" if ESPTOOLPY_FLASHSIZE_1MB
default "2MB-c1" if ESPTOOLPY_FLASHSIZE_2MB_C1
default "4MB-c1" if ESPTOOLPY_FLASHSIZE_4MB_C1
default "8MB" if ESPTOOLPY_FLASHSIZE_8MB
Expand Down Expand Up @@ -152,7 +155,9 @@ choice ESPTOOLPY_AFTER
boards do this internally.

config ESPTOOLPY_AFTER_RESET
bool "Reset after flashing"
bool "Hard Reset after flashing"
config ESPTOOLPY_AFTER_SOFT_RESET
bool "Soft Reset after flashing"
config ESPTOOLPY_AFTER_NORESET
bool "Stay in bootloader"
endchoice
Expand All @@ -161,6 +166,7 @@ config ESPTOOLPY_AFTER
string
default "hard_reset" if ESPTOOLPY_AFTER_RESET
default "no_reset" if ESPTOOLPY_AFTER_NORESET
default "soft_reset" if ESPTOOLPY_AFTER_SOFT_RESET

choice MONITOR_BAUD
prompt "'make monitor' baud rate"
Expand Down