Add some example I/O #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
jesserockz
requested changes
Jul 9, 2025
| void EmptyI2CSensor::update(){ | ||
|
|
||
| void EmptyI2CSensor::update() { | ||
| // Work to be done at each update interval |
There was a problem hiding this comment.
Maybe read some bytes and publish state?
|
|
||
| void EmptySPISensor::loop() { | ||
|
|
||
| // Work to be done at each update interval |
| this->mark_failed(); // Mark the component as failed if the response is not | ||
| // as expected | ||
| return; | ||
| } | ||
| } | ||
|
|
||
| void EmptyUARTComponent::loop() { | ||
|
|
There was a problem hiding this comment.
Maybe show reading the bytes while available then calling something like parse_bytes or whatever is more common in ESPHome
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
jesserockz
approved these changes
Jul 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSIA