[feat] Add esptool logs to install web dialog #707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@balloob could we get that merged? |
balloob
reviewed
May 5, 2025
| super.connectedCallback(); | ||
|
|
||
| // this._console won't be defined until after the first paint | ||
| setTimeout(() => { |
There was a problem hiding this comment.
this.updateComplete is a promise that resolves once update is complete. There is also an updated callback.
balloob
reviewed
May 5, 2025
| @@ -148,7 +180,7 @@ export class ESPHomeInstallWebDialog extends LitElement { | |||
| <div class="icon">${icon}</div> | |||
| ${label} | |||
| </div> | |||
| ${showClose | |||
| ${showClose || true | |||
|
@ximex it would need some more review |
|
Yeah there's still some polish needed here. Hoping to take another look at this soon.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the output of the
esptoollogs to the installer dialogesptool-logs.mp4