Properly handle u8 pointers when assigning and comparing #8818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcspr
changed the title
d-a-v
approved these changes
Jan 20, 2023
|
Just as a compliment: |
s-hadinger
added a commit
to tasmota/arduino-esp32
that referenced
this pull request
Nov 1, 2023
s-hadinger
added a commit
to tasmota/arduino-esp32
that referenced
this pull request
Nov 1, 2023
Jason2866
added a commit
to tasmota/arduino-esp32
that referenced
this pull request
Nov 11, 2023
* IPv6 support * remove WPA2 Enterprise * fix include with newer IDF5.1 * rm `WiFiClientSecure` * "--dont-append-digest" * add C2 * rm BluetoothSerial * safeboot in Tasmota project * Apply IPAddress fixes from ESP8266 esp8266/Arduino#8818 * [ESP32-C2] Fix SPI bus number & reported flash speed/size --------- Co-authored-by: Stephan Hadinger <stephan.hadinger@gmail.com> Co-authored-by: TD-er <gijs.noorlander@gmail.com>
Jason2866
added a commit
to tasmota/arduino-esp32
that referenced
this pull request
Nov 21, 2023
* IPv6 support * remove WPA2 Enterprise * fix include with newer IDF5.1 * rm `WiFiClientSecure` * "--dont-append-digest" * rm BluetoothSerial * safeboot in Tasmota project * Apply IPAddress fixes from ESP8266 esp8266/Arduino#8818 * Revert "WiFiSTA - allow using DHCP again after disconnecting static IP (espressif#8848)" (#297) * remove zigbee libs --------- Co-authored-by: Stephan Hadinger <stephan.hadinger@gmail.com> Co-authored-by: TD-er <gijs.noorlander@gmail.com>
Jason2866
added a commit
to tasmota/arduino-esp32
that referenced
this pull request
Nov 21, 2023
* IPv6 support * remove WPA2 Enterprise * fix include with newer IDF5.1 * rm `WiFiClientSecure` * "--dont-append-digest" * rm BluetoothSerial * safeboot in Tasmota project * Apply IPAddress fixes from ESP8266 esp8266/Arduino#8818 * Revert "WiFiSTA - allow using DHCP again after disconnecting static IP (espressif#8848)" (#297) * remove zigbee libs --------- Co-authored-by: Stephan Hadinger <stephan.hadinger@gmail.com> Co-authored-by: TD-er <gijs.noorlander@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
raw6() is one thing left over, we sometimes have
u8 scopeat the end so it is not techically valid code to reinterpret like that. alignment works out, thoughtbh I'd prefer we return a real value instead of pointer for our internal usage, and leave ptr access for Arduino compatibility (meaning, std::array<uint8_t, 4> and std::array<uint16_t, 8> / std::array<uint8_t, 16> and operate on that vs. weird overloads all over the place and no size checks)