Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Servo: re-attach to same value (position) #8753

Merged
merged 2 commits into from
Dec 14, 2022

Conversation

dok-net
Copy link
Contributor

@dok-net dok-net commented Dec 10, 2022

The current implementation of the Servo lib always resets the position when detaching.
In AVR Servo, this isn't the case, instead, it doesn't move the servo but leaves it as it was before getting detached.
Fixes #8752.
Should obviate #8723

@dok-net dok-net changed the title Re-attach to same value (position) Servo: re-attach to same value (position) Dec 10, 2022
@mcspr
Copy link
Collaborator

mcspr commented Dec 14, 2022

I guess, approved by @om2804?
By AVR Servo, you mean https://github.com/arduino-libraries/Servo?
(also includes sam,samd,nrf52 and stm)

@dok-net
Copy link
Contributor Author

dok-net commented Dec 14, 2022

@mcspr Yes, the original Arduino Servo lib.

@mcspr mcspr merged commit 64077df into esp8266:master Dec 14, 2022
@dok-net dok-net deleted the 8752-servo-reattach branch December 23, 2022 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-attaching servo causes erratic movement
3 participants