WString: unify numeric conversion and fix assignments #8526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restore the pre-3.0.0 behaviour when we could assign numeric values to the string object. After introducing `operator =(char)`, everything was converted to `char` instead of the expected 'stringification' of the number (built-in int, long, unsigned int, unsigned long, long long, unsigned long long, float and double)
|
|
… decimalPlaces
branch via if (base == 10) { sprintf(...) } else { ... } instead of separate funcs
reuse the constructor for numeric types where it's possible
nonstd arduino funcs expect this usage pattern
also -1 line
mcspr
commented
Mar 31, 2022
Comment on lines
-67
to
-77
| explicit String(unsigned char, unsigned char base = 10); | ||
| explicit String(int, unsigned char base = 10); | ||
| explicit String(unsigned int, unsigned char base = 10); | ||
| explicit String(long, unsigned char base = 10); | ||
| explicit String(unsigned long, unsigned char base = 10); | ||
| explicit String(long long /* base 10 */); | ||
| explicit String(long long, unsigned char base); | ||
| explicit String(unsigned long long /* base 10 */); | ||
| explicit String(unsigned long long, unsigned char base); | ||
| explicit String(float, unsigned char decimalPlaces = 2); | ||
| explicit String(double, unsigned char decimalPlaces = 2); |
There was a problem hiding this comment.
This one is mostly for verbosity. Due to the amount of magic ctors we have... we can't really have std::initializer_list<char> ctor as well, since everything would be converted into it
e.g.
String(std::initializer_list<char> data) {
concat(data.begin(), data.size());
}So only purpose of the below is to allow to omit String{...} in front of the arguments list. Where we suppose to have explicit for String(int, base) overload
core/test_string.cpp:620:51: error: converting to ‘String’ from initializer list would use explicit constructor ‘String::String(int, unsigned char)’
620 | String strings[] {{62, 10}, {63, 10}, {64, 10}};
| ^Could be reverted though.
d-a-v
approved these changes
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore the pre-3.0.0 behaviour when we could assign numeric values to
the string object. After introducing
operator =(char), everything wasconverted to
charinstead of the expected 'stringification' of thenumber (built-in int, long, unsigned int, unsigned long, long long,
unsigned long long, float and double)
Add
toString()that handles conversions, re-use it through out the classFix #8430