Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heap panic / abort cleanup #8465

Merged
merged 5 commits into from
Mar 31, 2022

Conversation

mhightower83
Copy link
Contributor

Isolate NULL/panic test of _context to dev debug assert macro.

Use abort instead of panic for the case of the caller providing a non-heap address pointer.

  • Added debug print.
  • Improved get_unpoisoned_check_neighbors to print file/line when available.

Isolate NULL/panic test of _context to dev debug assert macro.

Use abort instead of panic for case of caller providing non-heap address pointer.
  Added debug print.
  Improved get_unpoisoned_check_neighbors to print file/line when available.
Copy link
Collaborator

@d-a-v d-a-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing jumps at me in this code simplification.
Thank you for keeping improving the undergrounds and UMM

@d-a-v d-a-v added this to the 3.1 milestone Feb 15, 2022
@d-a-v d-a-v added the alpha included in alpha release label Mar 3, 2022
@mcspr
Copy link
Collaborator

mcspr commented Mar 30, 2022

Should be ok to merge then?

@mcspr mcspr merged commit fbedcc1 into esp8266:master Mar 31, 2022
@mhightower83 mhightower83 deleted the pr-umm_malloc-panic-cleanup branch April 21, 2022 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alpha included in alpha release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants