StreamConstPtr: disallow passing a String temporary #8410
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unless using it like this:
using
auto var = StreamConstPtr(String-Temporary)
leads to errors because it stores an expected-to-be invalid pointer.This PR prevents from using temporary
String
withStreamConstPtr
.(note :
StreamConstPtr("test").sendAll(elsewhere)
is implicitely using an intermediateString
)edit:
+ missing virtual destructor in
Stream::