-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update certs-from-mozilla.py #7578
Conversation
Check if ar exists, if not tell the user what to get to prevent issue esp8266#7300 also dynamically get certs instead of hardcoded row item esp8266#7573 (comment)
Thanks ! |
@d-a-v So assuming someone is a new user that just wants to make SSL requests with this. How does he find ar or get.py? Is there any documentation that I can link to that shows the user how to get ar? I assume ar is /Java/hardware/tools/avr/bin/avr-ar? |
There are three ways to install:
You are running Arduino IDE on macOS. That one is not the good one. But documentation should refer to a relative path like |
@d-a-v Thank you, can I just link your comment in the python script so users that stumble over this issue can see what to do? |
Not this comment's URL. That would be sufficient :
|
changed comment for missing ar exception
I added your path. But since I don't have this path and didn't use this repo to begin with with my esp8266 I'm not sure how useful this path is for anyone that stumbles over this. I assume most people that download the certs are coming here from 3rd party sites. |
You do have it. |
@earlephilhower Do we really need xtensa's ar ? Any version of Anyway, we know for sure that we always have this one |
I don't have Arduino in Application since I never moved it there. All I have in the Arduino package contents is a folder named arduino and tools, both have an avr folder inside. "we" excludes myself then I guess. If others have the path then thats fine. I just got ar from somewhere else and ran the script inside the folder with ar and that fixed it. |
I suggest you to test the existence of openssl as well. |
I think we should update the path with this one because it is always present in a working setup (the current one is
@JiriBilek that's right
|
updated path and check for openssl
changed path and added openssl check @d-a-v |
libraries/ESP8266WiFi/examples/BearSSL_CertStore/certs-from-mozilla.py
Outdated
Show resolved
Hide resolved
added linebreak for comment
Thanks for making this script more generic ! |
* master: (299 commits) Fix error message typo (esp8266#7581) Update certs-from-mozilla.py (esp8266#7578) Update DigestAuthorization.ino (Simple example update) (esp8266#7579) Fix gzip+signed OTA error (esp8266#7577) Properly replace toolchain in PlatformIO CI script (esp8266#7580) Update certs-from-mozilla.py (esp8266#7573) Fixup weird combination of oneline/multi line comments (esp8266#7566) Reduce codesize of setOutputPower (esp8266#7572) Fix typos in tests Force gcc inlining, use same style for getCycleCount as for getCpuFreqMHz. Even more concise #if form. Inline, fewer LOC, remove redundant definition in cpp. Netump Initial commit (esp8266#7527) Delete owner field (esp8266#7563) Avoid float-double-conversion (esp8266#7559) Use direct member initialization instead of ctr initialisation (esp8266#7556) Add CI test for eboot build (esp8266#7546) getCpuFreqMHz(): fix when F_CPU is not defined (esp8266#7554) emulation-on-host makefile update, allowing to pass more options (esp8266#7552) add sdk options to "generic esp8285 module" (esp8266#7550) ...
Check if ar exists, if not tell the user what to get to prevent issue #7300 also dynamically get certs instead of hardcoded row item #7573 (comment)