Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment out verify step in eboot.c #7468

Merged
merged 2 commits into from
Jul 21, 2020
Merged

Comment out verify step in eboot.c #7468

merged 2 commits into from
Jul 21, 2020

Conversation

devyte
Copy link
Collaborator

@devyte devyte commented Jul 18, 2020

Meant for #7458 , but still requires a recompiled eboot.elf.

@devyte
Comment out verify step in eboot.c
68bf59e 
Meant for #7458 , but still requires a recompiled eboot.elf.
earlephilhower
earlephilhower requested changes Jul 21, 2020
View reviewed changes
Copy link
Collaborator

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebuild eboot.elf and add to the commit.

@Tech-TX Tech-TX mentioned this pull request Jul 21, 2020
Closed
@devyte
Copy link
Collaborator Author

devyte commented Jul 21, 2020

Testing by @Tech-TX shows ok.
ToDo, but in a different PR and target: implement some alternate form of verification, e. g. with hash calc.

@devyte devyte merged commit c94d36d into master Jul 21, 2020
@devyte devyte added this to the 3.0.0 milestone Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@earlephilhower earlephilhower earlephilhower approved these changes

Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@devyte @earlephilhower