Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change test URL #7370

Merged
merged 4 commits into from
Jul 16, 2020
Merged

Change test URL #7370

merged 4 commits into from
Jul 16, 2020

Conversation

kinafu
Copy link
Contributor

@kinafu kinafu commented Jun 12, 2020

www.github.com forwards to github.com
So reaching out for "www.github.com" returns HTTP 304 instead of the nice HTTP 204

earlephilhower
earlephilhower requested changes Jun 12, 2020
View reviewed changes
Copy link
Collaborator

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but this changes only the printout and does not change the actual URL.

The test itself is checking SSL connectivity which is required to get the 301 REDIRECT anyway, so as long as the URL resolves to an active webserver, it should be good to go.

@kinafu
Change test URL
94060f2 
github.com forwards to www.github.com
So reaching out for "www.github.com" returns HTTP 304 instead of the nice HTTP 204
@earlephilhower earlephilhower merged commit 709ba79 into esp8266:master Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@earlephilhower earlephilhower earlephilhower approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kinafu @earlephilhower