Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the bad address of the the AP if the settings are wrong #7363

Merged
merged 2 commits into from
Jun 8, 2020

Conversation

dumarjo
Copy link
Contributor

@dumarjo dumarjo commented Jun 8, 2020

Hi,
This should fix the problem seen from time to time on our device. The default IP should be 192.168.4.1 and not 192.168.244.1

This should fix this issue: #5627

Fix the bad adress of the the AP if the settings are wrong
@d-a-v d-a-v added this to the 3.0.0 milestone Jun 8, 2020
@devyte
Copy link
Collaborator

devyte commented Jun 8, 2020

This is a long standing bug. We don't support user reliance on a bug. Moving to 2.7.2.

@devyte devyte modified the milestones: 3.0.0, 2.7.2 Jun 8, 2020
@devyte
Copy link
Collaborator

devyte commented Jun 8, 2020

@dumarjo thanls for this. Also, shame on me, because I know I've seen that line in the past, and wondered about it.

@devyte devyte merged commit 5473656 into esp8266:master Jun 8, 2020
Copy link

@thekurtovic thekurtovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ret = softAPConfig(0x0104A8C0, 0x00F4A8C0, 0x00FFFFFF);
should be
ret = softAPConfig(0x0104A8C0, 0x0104A8C0, 0x00FFFFFF);

@devyte devyte mentioned this pull request Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants