Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hold transmitter in reset during rate change #7248

Merged
merged 2 commits into from
Apr 27, 2020
Merged

Hold transmitter in reset during rate change #7248

merged 2 commits into from
Apr 27, 2020

Conversation

geoffday67
Copy link
Contributor

No description provided.

earlephilhower
earlephilhower approved these changes Apr 26, 2020
View reviewed changes
Copy link
Collaborator

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and see no issue. I never ran into the underlying problem before, but I can see where there is a potential race condition (I2SC updated in 2 steps, and might start working immediately after the 1st write and have garbage in some bits).

@earlephilhower earlephilhower added this to the 2.7.0 milestone Apr 26, 2020
@devyte devyte merged commit ec76442 into esp8266:master Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@earlephilhower earlephilhower earlephilhower approved these changes

@devyte devyte devyte approved these changes

Assignees
No one assigned
Labels
component: core type: enhancement
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@geoffday67 @earlephilhower @devyte