Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing listen to listen the current iface only instead of 0 #7217

Merged
merged 3 commits into from
Apr 17, 2020
Merged

Changing listen to listen the current iface only instead of 0 #7217

merged 3 commits into from
Apr 17, 2020

Conversation

BbIKTOP
Copy link
Contributor

@BbIKTOP BbIKTOP commented Apr 16, 2020 •
edited
Loading

Fixes #7213

d-a-v
d-a-v approved these changes Apr 16, 2020
View reviewed changes
Copy link
Collaborator

@d-a-v d-a-v left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could ping both mDNS names using two mDNS responder instances.

(edit: only when connected to the right access point)

Thanks !

@devyte devyte merged commit 77b82a0 into esp8266:master Apr 17, 2020
@BbIKTOP BbIKTOP deleted the mDNS_listen_fix branch April 21, 2020 20:03
@jjsuwa jjsuwa mentioned this pull request May 3, 2020
Closed
devyte pushed a commit that referenced this pull request May 3, 2020
@jjsuwa
Revert "Changing listen to listen the current iface only instead of 0" (
bf718c3 
#7266)

workaround for #7262 (reverts #7217)

Co-authored-by: Takayuki 'January June' Suwa <jjsuwa.sys3175@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-a-v d-a-v d-a-v approved these changes

@devyte devyte devyte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Second mdns instance cannot be started
4 participants
@BbIKTOP @d-a-v @devyte @earlephilhower