Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attribute __real_system_restart_local() as (noreturn) #7167

Merged
merged 3 commits into from
Mar 26, 2020
Merged

Attribute __real_system_restart_local() as (noreturn) #7167

merged 3 commits into from
Mar 26, 2020

Conversation

jjsuwa
Copy link
Contributor

@jjsuwa jjsuwa commented Mar 26, 2020

As well as abort().

@d-a-v
Copy link
Collaborator

d-a-v commented Mar 26, 2020

What would be nice is to move repeated declarations into a single dedicated file
core/esp8266/coredecls.h

Attribute __real_system_restart_local() as (noreturn) [v2]
34e91ef 
* As well as `abort()`.

* Aggragate two decls into `coredecls.h`.
@d-a-v d-a-v merged commit 631f66b into esp8266:master Mar 26, 2020
@jjsuwa jjsuwa deleted the reset_as_noreturn branch March 26, 2020 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-a-v d-a-v d-a-v approved these changes

@devyte devyte devyte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jjsuwa @d-a-v @devyte