-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fileCreation/getCreation create-time accessors #7000
Merged
Merged
Commits on Jan 8, 2020
-
Add fileCreation/getCreation create-time accessors
For SDFS and LittleFS, enable a creation time accessor for files and Dir iterators, similar to the existing fileTime/getLastWrite calls. Remove spurious Dir::getLastWrite method (the proper and only documented way is really Dir::fileTime). Update json to point to new mklittlefs which copies the creation date of files to the image. Fixes esp8266#6992
Configuration menu - View commit details
-
Copy full SHA for cafc27f - Browse repository at this point
Copy the full SHA cafc27fView commit details
Commits on Jan 11, 2020
-
Remove malloc(), use stack vars for temp names
LFS filenames are limited in size and generally very small. Use a stack variable instead of a dynamic allocation when performing full-path computations.
Configuration menu - View commit details
-
Copy full SHA for 39ecd9c - Browse repository at this point
Copy the full SHA 39ecd9cView commit details -
Replace "Creation" w/"CreationTime" in FS accessor
Per review, `getCreation` -> `getCreationTime`, `fileCreation` -> `fileCreationTime`. The names `fileTime()` and `getLastWrite()` are inherited from ESP32 implementation and unchanged.
Configuration menu - View commit details
-
Copy full SHA for b06959f - Browse repository at this point
Copy the full SHA b06959fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 498d950 - Browse repository at this point
Copy the full SHA 498d950View commit details
Commits on Jan 19, 2020
-
Enable SdFat's sateTime callback for timestamping
SdFat requries the dateTimeCallback call (global for everything) to update dates and times on created files. Because the callback signature doesn't have space for us to provide any parameters, we cannot get the the File, Dir, or FS object's dateTimeCB member. Instead, just go with `time(null)` as the callback function which is right in all but the most esoteric cases.
Configuration menu - View commit details
-
Copy full SHA for 76a0a1d - Browse repository at this point
Copy the full SHA 76a0a1dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 61a0dc8 - Browse repository at this point
Copy the full SHA 61a0dc8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4fb8bfe - Browse repository at this point
Copy the full SHA 4fb8bfeView commit details
Commits on Jan 20, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 9db7e78 - Browse repository at this point
Copy the full SHA 9db7e78View commit details
Commits on Feb 8, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 454feeb - Browse repository at this point
Copy the full SHA 454feebView commit details
Commits on Feb 21, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 3a0dc9b - Browse repository at this point
Copy the full SHA 3a0dc9bView commit details
Commits on Feb 22, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 01c7554 - Browse repository at this point
Copy the full SHA 01c7554View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7318f90 - Browse repository at this point
Copy the full SHA 7318f90View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.