Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix send error header sometime and add collectAllHeaders() function #2713

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kingxf1995
Copy link

Fix send error header when url is like "http://github.com" (not end with '/').
Add collectAllHeaders() to support collecting all response headers. Old collectHeaders() can not handle two header with the same name.

…th '/').

Add collectAllHeaders() to support collecting all response headers. Old collectHeaders() can not handle two header with the same name.
@codecov-io
Copy link

codecov-io commented Nov 24, 2016

Current coverage is 27.80% (diff: 100%)

Merging #2713 into master will not change coverage

@@             master      #2713   diff @@
==========================================
  Files            20         20          
  Lines          3625       3625          
  Methods         335        335          
  Messages          0          0          
  Branches        656        656          
==========================================
  Hits           1008       1008          
  Misses         2441       2441          
  Partials        176        176          

Powered by Codecov. Last update 7b32e6a...daf9195

@kingxf1995
Copy link
Author

kingxf1995 commented Nov 25, 2016

If use this code

httpclient.begin("http://xxx.xxx.xxx");
code = httpclient.GET();

The httpclient will send

GET HTTP/1.1
Host: xxx.xxx.xxx
User-Agent: ESP8266HTTPClient
Connection: close
Accept-Encoding: identity;q=1,chunked;q=0.1,*;q=0

But it is a bad request, after fix httpclient will send

GET / HTTP/1.1
Host: xxx.xxx.xxx
User-Agent: ESP8266HTTPClient
Connection: close
Accept-Encoding: identity;q=1,chunked;q=0.1,*;q=0

@earlephilhower earlephilhower added merge-conflict PR has a merge conflict that needs manual correction waiting for feedback Waiting on additional info. If it's not received, the issue may be closed. labels Oct 1, 2019
@earlephilhower
Copy link
Collaborator

Thanks for your PR, but the core and libraries have changed enough that this PR now has a merge conflict.

Could you merge it manually with the latest core, so we can consider it for future releases?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-conflict PR has a merge conflict that needs manual correction waiting for feedback Waiting on additional info. If it's not received, the issue may be closed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants