Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] Board specific defines are generic for some variants #6805

Closed
sprior opened this issue Nov 19, 2019 · 3 comments · Fixed by #7875
Closed

[feature request] Board specific defines are generic for some variants #6805

sprior opened this issue Nov 19, 2019 · 3 comments · Fixed by #7875
Milestone

Comments

@sprior
Copy link

sprior commented Nov 19, 2019

I have noticed that ARDUINO_BOARD and the ARDUINO_**** #defines are nicely specific for some variants of ESP8266 but frustratingly generic on others.

Note that there is no way to use the current definitions to differentiate between NodeMCU 0.9 and NodeMCU 1.0 or the Adafruit HUZZAH.

Unless there is a compelling reason not to I'd suggest that it is desirable to be able to use preprocessor ifdefs to detect each variant of device.

Some examples from boards.txt are:

huzzah.name=Adafruit Feather HUZZAH ESP8266
huzzah.build.board=ESP8266_ESP12

inventone.name=Invent One
inventone.build.board=ESP8266_GENERIC

cw01.name=XinaBox CW01
cw01.build.board=ESP8266_GENERIC

nodemcu.name=NodeMCU 0.9 (ESP-12 Module)
nodemcu.build.board=ESP8266_NODEMCU

nodemcuv2.name=NodeMCU 1.0 (ESP-12E Module)
nodemcuv2.build.board=ESP8266_NODEMCU

espino.name=ESPino (ESP-12 Module)
espino.build.board=ESP8266_ESP12

espinotee.name=ThaiEasyElec's ESPino
espinotee.build.board=ESP8266_ESP13

@sprior sprior changed the title Board specific defines are generic for some boards Board specific defines are generic for some variants Nov 19, 2019
@sprior sprior changed the title Board specific defines are generic for some variants [feature request] Board specific defines are generic for some variants Nov 19, 2019
@d-a-v d-a-v added this to the 3.0.0 milestone Nov 9, 2020
@d-a-v
Copy link
Collaborator

d-a-v commented Jan 28, 2021

#7839 fixed this, no ?
@earlephilhower

@d-a-v d-a-v removed their assignment Jan 28, 2021
earlephilhower added a commit to earlephilhower/Arduino that referenced this issue Feb 13, 2021
Fixes esp8266#6805

Update the build.board for several boards which were originally added
with a generic type.
@earlephilhower
Copy link
Collaborator

Only the ones as ESP8266_GENERIC were updated. A new PR is forthcoming for the rest.

@sprior
Copy link
Author

sprior commented Feb 13, 2021

Nice! I look forward to the release.

d-a-v pushed a commit that referenced this issue Feb 14, 2021
Fixes #6805

Update the build.board for several boards which were originally added
with a generic type.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants