Avoid Delegate anti-pattern (std::function with capture where C-style ptr with arg is possible).

Author: dok-net

libraries/ESP8266WiFi/src/ESP8266WiFiGeneric.cpp

@@ -434,7 +434,7 @@ bool ESP8266WiFiGenericClass::mode(WiFiMode_t m) {
     //tasks to wait correctly.
     constexpr unsigned int timeoutValue = 1000; //1 second
     if(can_yield()) {
-        esp_delay(timeoutValue, [m]() { return wifi_get_opmode() != (uint8)m; }, 5);
+        esp_delay(timeoutValue, { [](void* m) { return wifi_get_opmode() != *static_cast<WiFiMode_t*>(m); }, (void*)&m }, 5);
 
         //if at this point mode still hasn't been reached, give up
         if(wifi_get_opmode() != (uint8) m) {

libraries/ESP8266WiFi/src/include/ClientContext.h

@@ -145,7 +145,7 @@ class ClientContext
         _op_start_time = millis();
         // will resume on timeout or when _connected or _notify_error fires
         // give scheduled functions a chance to run (e.g. Ethernet uses recurrent)
-        esp_delay(_timeout_ms, [this]() { return _connect_pending; }, 1);
+        esp_delay(_timeout_ms, { [](void* self) { return static_cast<ClientContext*>(self)->_connect_pending; }, this }, 1);
         _connect_pending = false;
         if (!_pcb) {
             DEBUGV(":cabrt\r\n");
@@ -486,7 +486,7 @@ class ClientContext
             _send_waiting = true;
             // will resume on timeout or when _write_some_from_cb or _notify_error fires
             // give scheduled functions a chance to run (e.g. Ethernet uses recurrent)
-            esp_delay(_timeout_ms, [this]() { return _send_waiting; }, 1);
+            esp_delay(_timeout_ms, { [](void* self) { return static_cast<ClientContext*>(self)->_send_waiting; }, this }, 1);
             _send_waiting = false;
         } while(true);