Merge pull request #7027 from dok-net/wmath_map

Fix WMath's map() implementation for inverse/round-trip mapping
esp8266 · Feb 9, 2020 · 56b90a2 · 56b90a2 · TD-er · Feb 10, 2020
2 parents 50a491b + cd5cbae
commit 56b90a2
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/cores/esp8266/WMath.cpp b/cores/esp8266/WMath.cpp
@@ -70,11 +70,11 @@ long secureRandom(long howsmall, long howbig) {
 }
 
 long map(long x, long in_min, long in_max, long out_min, long out_max) {
-    long divisor = (in_max - in_min);
-    if(divisor == 0){
-        return -1; //AVR returns -1, SAM returns 0
-    }
-    return (x - in_min) * (out_max - out_min) / divisor + out_min;
+    const long dividend = out_max - out_min;
+    const long divisor = in_max - in_min;
+    const long delta = x - in_min;
+
+    return (delta * dividend + (divisor / 2)) / divisor + out_min;
 }
 
 unsigned int makeWord(unsigned int w) {