Skip to content

Use fewer embedded-hal@0.2.x traits in examples, build HAL without default features in CI #1372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 1, 2024

Conversation

jessebraham
Copy link
Member

This branch turned into a bit of a grab bag of changes, and nothing too exciting here, but the gist is:

@jessebraham jessebraham added the skip-changelog No changelog modification needed label Apr 1, 2024
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for taking care of this. I'm not sure if GHA is bugged or there some jobs that aren't starting for some reason?

@MabezDev MabezDev enabled auto-merge April 1, 2024 16:21
@jessebraham jessebraham marked this pull request as draft April 1, 2024 16:34
auto-merge was automatically disabled April 1, 2024 16:34

Pull request was converted to draft

@jessebraham
Copy link
Member Author

Ahh it's because the CI jobs changed, and we need to explicitly configure the CI job names in the repo settings. Really annoying, I don't feel like dealing with it right now so will fix it tomorrow.

@jessebraham
Copy link
Member Author

Okay just kidding, easy fix

@jessebraham jessebraham marked this pull request as ready for review April 1, 2024 17:25
@jessebraham jessebraham enabled auto-merge April 1, 2024 17:26
@jessebraham jessebraham added this pull request to the merge queue Apr 1, 2024
Merged via the queue into esp-rs:main with commit 99b0c77 Apr 1, 2024
21 checks passed
@jessebraham jessebraham deleted the fixes/embedded-hal branch April 2, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog No changelog modification needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants