Skip to content

chore: Update dependencies and remove submodules #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 20, 2025
Merged

Conversation

finger563
Copy link
Contributor

Description

  • Remove submodules
  • Use idf component manager to pull in necessary dependencies
  • Add associated idf component file (to mark dependencies)
  • Update CMakeLists accordingly

Motivation and Context

Helps keep the repo up to date without requiring as much work. Decreases clone time and file system utilization of repo.

How has this been tested?

Build and run main on esp32-timer-cam hardware.

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

Copy link

github-actions bot commented May 20, 2025

✅Static analysis result - no issues found! ✅

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates dependency management by removing submodules and switching to the IDF component manager while also refreshing build configurations and workflows. Key changes include:

  • Removing submodules and updating associated configuration files.
  • Updating CMakeLists.txt to require CMake 3.20 and adjusting component paths.
  • Revising GitHub workflows and the main application code for updated dependency versions and lambda parameter types.

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
sdkconfig.defaults Removed an unused SPIRAM mode config and added camera-specific config.
main/main.cpp Changed lambda parameters to const references for better const safety.
main/idf_component.yml Added an IDF component manifest with updated dependency versions.
components/espp Removed the espp submodule.
components/esp32-camera Updated the submodule commit URL and commit hash.
components/esp-protocols Removed the esp-protocols submodule.
CMakeLists.txt Updated CMake version to 3.20 and removed paths for submodule directories.
.gitmodules Removed entries for several submodules and updated the camera submodule URL.
.github/workflows/static_analysis.yml Updated ESP-IDF version and cppcheck arguments.
.github/workflows/package_main.yml Revised artifact upload configuration and updated action versions.
.github/workflows/build.yml Updated ESP-IDF version for the main build workflow.

@finger563 finger563 added the enhancement New feature or request label May 20, 2025
@finger563 finger563 merged commit a4633fc into main May 20, 2025
2 checks passed
@finger563 finger563 deleted the chore/dep-update branch May 20, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant