usb: host: Fix refcount leak in ehci_hcd_ppc_of_probe

Yuuoniy · gregkh · commit 3a50c917c67d · 2022-08-17T15:15:04.000+02:00
[ Upstream commit b5c5b13 ] of_find_compatible_node() returns a node pointer with refcount incremented, we should use of_node_put() on it when done. Add missing of_node_put() to avoid refcount leak. Fixes: 796bcae ("USB: powerpc: Workaround for the PPC440EPX USBH_23 errata [take 3]") Acked-by: Alan Stern <stern@rowland.harvard.edu> Signed-off-by: Miaoqian Lin <linmq006@gmail.com> Link: https://lore.kernel.org/r/20220602110849.58549-1-linmq006@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
diff --git a/drivers/usb/host/ehci-ppc-of.c b/drivers/usb/host/ehci-ppc-of.c
@@ -148,6 +148,7 @@ static int ehci_hcd_ppc_of_probe(struct platform_device *op)
 		} else {
 			ehci->has_amcc_usb23 = 1;
 		}
+		of_node_put(np);
 	}
 
 	if (of_get_property(dn, "big-endian", NULL)) {

Original file line number	Diff line number	Diff line change
`@@ -148,6 +148,7 @@ static int ehci_hcd_ppc_of_probe(struct platform_device *op)`
`148`	`148`	`} else {`
`149`	`149`	`ehci->has_amcc_usb23 = 1;`
`150`	`150`	`}`
	`151`	`+ of_node_put(np);`
`151`	`152`	`}`
`152`	`153`
`153`	`154`	`if (of_get_property(dn, "big-endian", NULL)) {`