fix: false positives in no-reversed-media-syntax (#521)

* wip

* wip

* wip

* wip: handle `Image`

* wip: handle `ImageReference`

* wip (error)

* wip

Author: lumirlumir

src/rules/no-reversed-media-syntax.js

@@ -9,7 +9,7 @@
 
 /**
  * @import { SourceRange } from "@eslint/core"
- * @import { Heading, Paragraph, TableCell, Html, InlineCode } from "mdast";
+ * @import { Heading, Paragraph, TableCell, Html, Image, ImageReference, InlineCode, LinkReference } from "mdast";
  * @import { MarkdownRuleDefinition } from "../types.js";
  * @typedef {"reversedSyntax"} NoReversedMediaSyntaxMessageIds
  * @typedef {[]} NoReversedMediaSyntaxOptions
@@ -102,8 +102,8 @@ export default {
 		}
 
 		return {
-			":matches(heading, paragraph, tableCell) :matches(html, inlineCode)"(
-				/** @type {Html | InlineCode} */ node,
+			":matches(heading, paragraph, tableCell) :matches(html, image, imageReference, inlineCode, linkReference)"(
+				/** @type {Html | Image | ImageReference | InlineCode | LinkReference} */ node,
 			) {
 				skipRanges.push(sourceCode.getRange(node));
 			},

tests/rules/no-reversed-media-syntax.test.js

@@ -74,6 +74,16 @@ ruleTester.run("no-reversed-media-syntax", rule, {
 		// Heading
 		"# [ESLint](https://eslint.org/)",
 		"# ![A beautiful sunset](sunset.png)",
+		// Image
+		"![()[]](hi)",
+		"![(hi)[something]](hi)",
+		"![()[]](https://example.com)",
+		// ImageReference
+		"![()[]][ref]\n\n[ref]: https://example.com",
+		"![(hi)[something]][ref]\n\n[ref]: https://example.com",
+		// LinkReference
+		"[()[]][ref]\n\n[ref]: https://example.com",
+		"[(hi)[something]][ref]\n\n[ref]: https://example.com",
 		// TableCell
 		{
 			code: dedent`
@@ -255,6 +265,20 @@ ruleTester.run("no-reversed-media-syntax", rule, {
 				},
 			],
 		},
+		{
+			code: "[^1]: !(Footnote alt)[https://example.com]",
+			output: "[^1]: ![Footnote alt](https://example.com)",
+			language: "markdown/gfm",
+			errors: [
+				{
+					messageId: "reversedSyntax",
+					line: 1,
+					column: 8,
+					endLine: 1,
+					endColumn: 43,
+				},
+			],
+		},
 		{
 			code: "[^1]: (Footnote text)[https://example.com]",
 			output: "[^1]: [Footnote text](https://example.com)",