fix: race conditions in fetch-team-data (#808)

Author: mdjermanovic

src/_data/all_authors.json

@@ -2,7 +2,7 @@
     "nzakas": {
         "username": "nzakas",
         "name": "Nicholas C. Zakas",
-        "title": "Guest Author",
+        "title": "ESLint Technical Steering Committee",
         "website": "https://humanwhocodes.com",
         "avatar_url": "https://avatars.githubusercontent.com/u/38546",
         "bio": "Creator of ESLint, independent software developer, consultant, coach, and author.",
@@ -104,7 +104,7 @@
     "hzoo": {
         "username": "hzoo",
         "name": "Henry",
-        "title": "Guest Author",
+        "title": "ESLint Alumnus",
         "website": "https://henryzoo.com",
         "avatar_url": "https://avatars.githubusercontent.com/u/588473",
         "bio": "Learning to maintain stuff",

tools/fetch-team-data.js

@@ -74,41 +74,44 @@ const octokit = new Octokit({
 	auth: ESLINT_GITHUB_TOKEN,
 });
 
-async function fetchUserProfile(username) {
-	// check cache first
-	if (users.has(username)) {
-		return users.get(username);
+function fetchUserProfile(username) {
+	async function doFetch() {
+		const { data: profile } = await octokit.users.getByUsername({
+			username,
+		});
+		const { data: social } = await octokit.request(
+			"GET /users/{username}/social_accounts",
+			{ username },
+		);
+		const avatarURL = `https://avatars.githubusercontent.com/u/${profile.id}`;
+
+		return {
+			username: profile.login,
+			name: profile.name,
+			title: "Guest Author",
+			// eslint-disable-next-line no-nested-ternary -- add https if missing
+			website: profile.blog.match(/http(s)?:\/\//u)
+				? profile.blog
+				: profile.blog
+					? `https://${profile.blog}`
+					: profile.blog,
+			avatar_url: avatarURL,
+			bio: profile.bio,
+			twitter_username: profile.twitter_username,
+			github_username: profile.login,
+			mastodon_url: social.find(
+				account => account.provider === "mastodon",
+			)?.url,
+			location: profile.location,
+		};
 	}
 
-	const { data: profile } = await octokit.users.getByUsername({ username });
-	const { data: social } = await octokit.request(
-		"GET /users/{username}/social_accounts",
-		{ username },
-	);
-	const avatarURL = `https://avatars.githubusercontent.com/u/${profile.id}`;
-
-	const result = {
-		username: profile.login,
-		name: profile.name,
-		title: "Guest Author",
-		// eslint-disable-next-line no-nested-ternary -- add https if missing
-		website: profile.blog.match(/http(s)?:\/\//u)
-			? profile.blog
-			: profile.blog
-				? `https://${profile.blog}`
-				: profile.blog,
-		avatar_url: avatarURL,
-		bio: profile.bio,
-		twitter_username: profile.twitter_username,
-		github_username: profile.login,
-		mastodon_url: social.find(account => account.provider === "mastodon")
-			?.url,
-		location: profile.location,
-	};
+	// Immediately store Promise in the cache to avoid race conditions
+	if (!users.has(username)) {
+		users.set(username, doFetch());
+	}
 
-	// cache the result
-	users.set(username, result);
-	return result;
+	return users.get(username);
 }
 
 async function fetchTeamMembers() {