fix(readonly-type): empty object types should not trigger reports

fix #796
eslint-functional · Apr 1, 2024 · fc6a394 · fc6a394
1 parent 052191c
commit fc6a394
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 8 deletions.
diff --git a/src/rules/readonly-type.ts b/src/rules/readonly-type.ts
@@ -178,14 +178,16 @@ function checkTypeLiteral(
   }
 
   if (mode === "generic") {
-    const needsWrapping = node.members.every(
-      (member) =>
-        (isPropertyDefinition(member) ||
-          isTSIndexSignature(member) ||
-          isTSParameterProperty(member) ||
-          isTSPropertySignature(member)) &&
-        member.readonly,
-    );
+    const needsWrapping =
+      node.members.length > 0 &&
+      node.members.every(
+        (member) =>
+          (isPropertyDefinition(member) ||
+            isTSIndexSignature(member) ||
+            isTSParameterProperty(member) ||
+            isTSPropertySignature(member)) &&
+          member.readonly,
+      );
 
     if (needsWrapping) {
       return {

diff --git a/tests/rules/readonly-type/ts/valid.ts b/tests/rules/readonly-type/ts/valid.ts
@@ -73,6 +73,13 @@ const tests: Array<ValidTestCaseSet<OptionsOf<typeof rule>>> = [
     `,
     optionsSet: [["keyword"]],
   },
+  // Empty should not cause issues
+  {
+    code: dedent`
+      type Foo = {};
+    `,
+    optionsSet: [["keyword"], ["generic"]],
+  },
 ];
 
 export default tests;